-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dbarok/athena dbt utils #380
Conversation
Hi thank you very much for dbt-utils, I added these changes so that we can use this also on Athena. Doing this for the first time so I'll appreciate any feedback or comments. Cheers! :) |
@dbarok This looks awesome! I'm glad you were able to add Athena support with just a handful of macros. We're trying to be really careful about the scope of this package, which has ballooned significantly over the past few years. As such, we've invested in functionality that enables adapter-specific macros to live in external "shim" packages. These packages can be installed alongside You can check out some example "shim" packages that are already up & running: A hypothetical
How does that sound to you? |
Great thanks for the explanation and the advice @jtcohen6 🙂 ! I will try to do it that way then. |
Thank you @dbarok for your work! I implemented the suggested solution of @jtcohen6 in the repository https://github.com/lalalilo/athena-utils Thanks again! |
Thanks for moving to the separate package!! Going to close this PR. |
This is a:
master
dev/
branchdev/
branchDescription & motivation
In our team we use dbt extensively hence we found it useful to have
dbt-utils
available also for Athena.Checklist
I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
I have "dispatched" any new macro(s) so non-core adapters can also use them (e.g. the
star()
source)I have updated the README.md (if applicable)
I have added tests & descriptions to my models (and macros if applicable)
I have added an entry to CHANGELOG.md