Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from template to dbt copyright #647

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Conversation

Maayan-s
Copy link
Contributor

I want to give proper attribution and licensing to code from dbt_utils that I'm using, so made this fix. Hope it's ok.

resolves #

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt.type_* macros instead of explicit datatypes (e.g. dbt.type_timestamp() instead of TIMESTAMP
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

I want to give proper attribution and licensing to code from dbt_utils that I'm using, so made this fix. Hope it's ok.
@joellabes
Copy link
Contributor

Thanks @Maayan-s! Sorry to keep you waiting - I'm 99.9% sure that this is fine, but just waiting to hear back from our legal team to be sure. Appreciate your patience!

LICENSE Outdated Show resolved Hide resolved
Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Maayan-s!

@joellabes joellabes merged commit ba7ee52 into dbt-labs:main Sep 19, 2022
joellabes added a commit that referenced this pull request Sep 28, 2022
#686)

* Update from template to dbt copyright (#647)

* Update from template to dbt copyright

I want to give proper attribution and licensing to code from dbt_utils that I'm using, so made this fix. Hope it's ok.

* Update LICENSE

* Limit columns selected in `expression_is_true` if failures not stored.

Fixes #683

Co-authored-by: Maayan Salom <maayansalom@gmail.com>
Co-authored-by: Joel Labes <joel.labes@dbtlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants