Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insert-by-period materialization #69

Merged
merged 5 commits into from
Jun 27, 2018

Conversation

clrcrl
Copy link
Contributor

@clrcrl clrcrl commented Jun 18, 2018

Adding a materialization to help build large models, by inserting records one period (day, week etc.) at a time

Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor docs requests, but this looks soo good. Excited to get it merged!

README.md Outdated
{{
config(
materialized = "insert_by_period",
period = "day" -- optional; period to break the model into - if not provided, "week" will be used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we slide the documentation out of the config() block? I think this is a syntax error, and it would be great if people could copy/paste in the example arguments to play around with

README.md Outdated
models:
project-name:
post-hook: "grant select on {{this}} to db_reader"
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add info about the workaround?

grant select on {{ this.schema }}.{{ this.name }} to db_reader

@drewbanin drewbanin merged commit 754db12 into dbt-labs:master Jun 27, 2018
@drewbanin drewbanin deleted the insert-by-period branch June 27, 2018 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants