Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a PR checklist item for "I have read the contributing guide..." as a catch-all #905

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

dbeatty10
Copy link
Contributor

resolves #904

This is a:

  • under the hood change

Problem

Our PR template is pretty long, which makes it onerous to use. Many items are already covered in our contribution guidelines in their own section.

Solution

Replace (4) checklist items with (1) checklist item that says:

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have read the contributing guide and understand what's expected of me
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@dbeatty10 dbeatty10 marked this pull request as ready for review June 4, 2024 21:13
@dbeatty10 dbeatty10 merged commit 2d1d810 into main Jun 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a PR checklist item for "I have read the contributing guide..." as a catch-all
1 participant