start_date and end_date casting fix #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @fivetran-joemarkiewicz! Tests don't run for the cloud ones because my cloud creds are busted, but there's no tests for start date anyway (yet) so... 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
As discussed within Issue #20. This PR explicitly casts the arguments for
start_dateandend_dateas dates. On my local branch, when this was not applied I received ano matching signatureerror in a downstream where clause.How were the changes tests
I tested this locally on my branch and was able to see the issue be resolved. It is strange that this was only happening on my local machine, but not on others. I wonder if this is a warehouse specific issue that I was experiencing on BigQuery. Regardless, with this update the issue didn't persist for me. Happy to discuss this in more detail if you would like!
Signed Individual Contributor Agreement?
Additional Context
Let me know if you would like me to update a CHANGELOG or make any other adjustments to this branch before merging. Thanks!