-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update run results docs to include compiled node attributes from dbt-core PR #8492 #4125
Comments
Looks like the schema version has been bumped to 5 |
@jtcohen6 is this for 1.7 or 1.8? I see it was removed from the 1.7 milestone and added to 1.8, but i believe this change was made for 1.7 |
@matthewshaver (apologies for commenting on all your issues) I think we should aim to have all issues addressed by Friday 2/23 to give reviewers and authors enough time. Let me know if you need support! |
## What are you changing in this pull request and why? Adding new attributes to `run_results.json`. Closes #4125 ## Checklist Uncomment when publishing docs for a prerelease version of dbt: - [x] Add versioning components, as described in [Versioning Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages) - [x] Add a note to the prerelease version [Migration Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/docs/dbt-versions/core-upgrade) - [x] Review the [Content style guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md) so my content adheres to these guidelines. - [x] For [docs versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning), review how to [version a whole page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version) and [version a block of content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
This was included in v1.7! Sorry for the confusion. I think it was removed from the milestone (not sure why); my motivation in re-adding a milestone was to make sure this got shipped, but it wasn't actually part of v1.8. |
dbt-labs/dbt-core#8492
Page to update
Content to update
In particular, update this section:
Also: "Current schema: v4" should be updated to v5 per here.
What changed?
dbt-labs/dbt-core#8492 added three new attributes related to "applied" state to
run_results.json
(to complementunique_id
):compiled
- boolean whether the node has been compiled or not (False
after parsing, butTrue
after compiling)compiled_code
- rendered string of the code that was compiled (empty after parsing, but full string after compiling)relation_name
- the fully-qualified name of the object that was (or will be) created/updated within the databaseAny additional information about the "logical" state of nodes should continue to be looked up in the full node object in manifest.json via the
unique_id
.Examples
Compile model
Create this model:
models/my_model.sql
Compile the model:
Look at a pretty-printed snippet from
run_results.json
:Run generic tests
Use the new
store_failures_as
config (#4246) to store failures for one test in the database, but not for the other:models/_models.yml
Run the built-in
unique
test (and store the failures as a table):dbt test -s my_model
Look at a pretty-printed snippet from
run_results.json
:cc: @peterallenwebb
The text was updated successfully, but these errors were encountered: