Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update seed configs to include delimiter from dbt-core PR #7186 #4126

Closed
FishtownBuildBot opened this issue Sep 25, 2023 · 2 comments · Fixed by #4265
Closed

Update seed configs to include delimiter from dbt-core PR #7186 #4126

FishtownBuildBot opened this issue Sep 25, 2023 · 2 comments · Fixed by #4265
Assignees
@runleonarun
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core improvement Use this when an area of the docs needs improvement as it's currently unclear
Milestone
dbt Core v1.7 Doc...

Comments

@FishtownBuildBot
Copy link

FishtownBuildBot commented Sep 25, 2023 •
edited by graciegoheen
Loading

We should update the seeds configuration page https://docs.getdbt.com/reference/seed-configs to include the new delimiter option.

seeds:
  <resource-path>:
    +quote_columns: true | false
    +column_types: {column_name: datatype}
    +delimiter: <string>

We should also make a new page (like https://docs.getdbt.com/reference/resource-configs/quote_columns) for the delimiter config for seeds.

delimiter defaults to a comma
@FishtownBuildBot FishtownBuildBot mentioned this issue Sep 25, 2023
Merged
6 tasks
@runleonarun runleonarun added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear dbt Core The changes proposed in this issue relate to dbt Core labels Sep 25, 2023
@graciegoheen graciegoheen changed the title Docs Changes Needed from dbt-core PR #7186 Update seed configs to include delimiter from dbt-core PR #7186 Sep 25, 2023
@jtcohen6 jtcohen6 added this to the dbt Core v1.7 Documentation milestone Oct 11, 2023
@runleonarun runleonarun self-assigned this Oct 11, 2023
@runleonarun runleonarun mentioned this issue Oct 12, 2023
Merged
7 tasks
@runleonarun
Copy link
Collaborator

@graciegoheen or @jtcohen6 is this being backported or should I version it?

@graciegoheen
Copy link
Collaborator

This is not being backported, so it's new starting in 1.7

runleonarun added a commit that referenced this issue Oct 13, 2023
@runleonarun @mirnawong1
@graciegoheen @matthewshaver
Adding configurable delimiters (#4265)
82bc1df 
Closes #4126 
Closes #4273

## What are you changing in this pull request and why?

* Adding delimiter to https://docs.getdbt.com/reference/seed-configs
* Adding new
https://docs.getdbt.com/reference/resource-configs/delimiter

## Checklist
<!--
Uncomment if you're publishing docs for a prerelease version of dbt
(delete if not applicable):
- [ ] Add versioning components, as described in [Versioning
Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages)
- [ ] Add a note to the prerelease version [Migration
Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/guides/migration/versions)
-->
- [ ] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
and [About
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
so my content adheres to these guidelines.
- [ ] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):
- [ ] Add page to `website/sidebars.js`
- [ ] Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):
- [ ] Remove page from `website/sidebars.js`
- [ ] Add an entry `website/static/_redirects`
- [ ] [Ran link
testing](https://github.com/dbt-labs/docs.getdbt.com#running-the-cypress-tests-locally)
to update the links that point to the deleted page

---------

Co-authored-by: mirnawong1 <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Grace Goheen <53586774+graciegoheen@users.noreply.github.com>
Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@runleonarun runleonarun

Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
dbt Core v1.7 Documentation
Development

Successfully merging a pull request may close this issue.

Adding configurable delimiters dbt-labs/docs.getdbt.com
4 participants
@runleonarun @jtcohen6 @graciegoheen @FishtownBuildBot