-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish Bitbucket CI/CD Article #1357
Conversation
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The quotes are the only thing that would cause a problem for someone copy-pasting the code.
|
||
alter schema dbt_ci owner to role_dev; | ||
|
||
create role dbt_bitbucket with login password ‘[password]’; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad single quotes
|
||
-- Grant all permissions required for the production role | ||
|
||
create role dev_ci with login password ‘[password]’; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad single quotes
|
||
You’ll need at least your dbt adapter-specific package, ideally pinned to a version. Mine is just | ||
|
||
`dbt-[adapter] ~= 1.0`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a code block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ehhh yea, yea, for consistency, even though it's one line it's still an entire file and we should make it a block.
|
||
It’s important to remember that CI/CD is a convenience, not a panacea. You must still devise the model logic and determine the appropriate tests. Some things it can do, though: catch more mistakes early, make sure that the database always reflects the most up-to-date code, and decrease the friction in collaboration. By automating the steps that should *always* be taken, it frees you up to think about the unusual steps required (e.g., do your changes to [incremental models](https://docs.getdbt.com/docs/building-a-dbt-project/building-models/configuring-incremental-models) require an additional deployment with `--full-refresh`?) and reduces the amount of review that others’ actions necessitate. | ||
|
||
Plus, it’s a good time, and it’s fun to watch the test lights turn green. Ding! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...I really can't think of another way to end this, but dear lord in heaven there must be a serious sentence somewhere out there, right? Alternately, I think this needs a gif to illustrate the "Ding!"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hahahah YES there's no turning back now this is The One ✅ .
also need to add an author page for you @shippy so we can add the frontmatter metadata -- if you want to either send me the stuff you want here or feel free to just pull this branch and add a commit! here's the existing ones for an example: https://github.com/dbt-labs/docs.getdbt.com/blob/current/website/blog/authors.yml |
Right - something like this: simon_podhajsky:
name: Simon Podhajsky
job_title: Data Lead
organization: iLife Technologies
description: >
Simon Podhajsky is a lapsed neuroscientist turned full-stack data engineer
at iLife Technologies, a startup that seeks to digitize the life insurance
agency.
image_url: /img/blog/authors/simon-podhajsky.png
links:
- url: https://www.linkedin.com/in/simonpodhajsky/
icon: fa-linkedin
- url: https://twitter.com/sim_pod
icon: fa-twitter I'll find a profile picture that fits and send it along. |
+1 to this and your author image! I believe you can also need to add a section to the beginning of the actual blog md where you have the title/author.etc. (example below). If you add this section, you can also remove the H1 # and text since the title tag will generate it for you (@gwenwindflower correct me if I'm wrong here)! The other styling thing is adding a truncate somewhere in the beginning of your blog md file where you feel it's appropriate! Feel free to look at the other blog posts to see where they've implemented them. |
@gwenwindflower I've made all the required changes but can't push to this repository -- wanna add me as a collaborator, or should I fork and make a PR to the PR? |
unfortunately @shippy i have to ask you to fork and PR your changes to my branch 😓 we have a limited number of seats for permissions for write access we're looking at some CMS options that might make this less of a pain in the ass -- with code it feels more understandable, but forking stuff to manage content definitely feels....extra...thanks for bearing with 🙏🏻 |
How lucky that I already have a fork for #1060 :) Will make the PR momentarily. |
…ticle Add frontmatter + truncate + gif to dev hub article in #1357
@johnblust this is ready to go whenever y'all are ready to publish 🙏🏻 -- feel free to merge away |
Thank you @gwenwindflower , this looks great! Thank you so much for the work you put into this ❤️ I'll need one of the reviewers to approve the PR before I am allowed to merge, though. @shippy an approved review from you might do the trick! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@johnblust I submitted an approving review, but I think Github (correctly) blocks the merge because an authorized review by @runleonarun or @annafil is required. |
@johnblust you technically actually can give it an approved review yourself since you have write access -- it's not limited to the folks autorequested, just anybody internal who has write access (this is why @shippy can't give it the ✅) but if process wise you're avoiding approving PRs, which i get, we could get @KiraFuruichi to 👍🏻 this one and lauren's ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sooo excited for this one!
@johnblust if you ever want to review code that you haven't been requested on you can go to the |
Learning something new everyday lol, thanks @gwenwindflower :) |
So it seems like there might be three things that need to happen:
@johnblust Is that something that you can do? Should I make another PR-to-this-PR? |
@shippy Yep! I've got it handled. Your article will be published this Friday, May 6th, on the Developer Blog sometime between 9am-10am ET. I can alert you via dbt Slack if you like! Then, on Monday, May 9th, we will share your article on our official LinkedIn and Twitter account at 8:30am ET if you would like to share/amplify with your own social pages. Also happy to alert you when the social push is live :) Very excited to get this published for you! |
@johnblust Thank you for taking care of it! No need for the separate alert, you're already doing plenty :) |
Description & motivation
This PR adds a new article to the Developer Blog from @shippy covering specifically how to enable Slim CI/CD on Bitbucket, alongside the general principles for applying this method on any currently (offically) unsupported/unintegrated development platform (everything outside Github and GitLab)
This closes #1322