Example of custom macros in get_where_subquery #2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
content
2 tasks
dbeatty10
requested changes
Nov 18, 2022
There was a problem hiding this comment.
This is... __wild__! Thank you for documenting this possibility!
It's an example of very __lightweight__, roll-your-own string interpolation using __magic__ strings rather than start/end delimiters. Now I'm curious how far an __enterprising__ person could get with defining and parsing their own delimiters!
(Feel free to go on your own Mad Libs® adventure and replace my comments above using the adjectives of your choice.)
Two things to resolve (both of which have inline suggestions):
- Choose either "use" or "access" as the MadLibs verb to proceed "custom macros" (but probably not both)
- Choose whether or not to namespace the
dateaddandcurrent_timestampmacros
Just picked some options so we can get this merged. Nothing stopping us from continuing to make updates if we change our minds.
dbeatty10
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
We get this question a lot:
Folks want to be able to stick custom macros in the
whereconfig for tests. While that isn't directly possible today — and that limitation is worth documenting explicitly — there's a halfway-decent workaround that's worth documenting.