Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redshift supports user grants but not groups #3245

Merged
merged 6 commits into from
Apr 25, 2023
Merged

Redshift supports user grants but not groups #3245

merged 6 commits into from
Apr 25, 2023

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Apr 21, 2023 •
edited
Loading

Preview > click "Redshift" tab

What are you changing in this pull request and why?

Redshift has users, groups, and roles. But the grants functionality only fully supports users (and not groups or roles).

See dbt-labs/dbt-redshift#415 for more context.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@dbeatty10 dbeatty10 requested a review from a team as a code owner April 21, 2023 23:47
@github-actions github-actions bot added the content Improvements or additions to content label Apr 21, 2023
@netlify
Copy link

netlify bot commented Apr 21, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit b69fed5
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/6447d1152b706d0007fb6f2b
😎 Deploy Preview https://deploy-preview-3245--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the size: small This change will take 1 to 2 days to address label Apr 21, 2023
@dbeatty10 dbeatty10 marked this pull request as draft April 21, 2023 23:48
@dbeatty10 dbeatty10 mentioned this pull request Apr 21, 2023
Open
2 tasks
@github-actions github-actions bot added size: x-small This change will take under 3 hours to fix. and removed size: small This change will take 1 to 2 days to address labels Apr 22, 2023
@dbeatty10 dbeatty10 marked this pull request as ready for review April 25, 2023 13:03
mirnawong1
mirnawong1 approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me @dbeatty10 - thank you for opening this up✨!

@dbeatty10 dbeatty10 merged commit fe3fcf4 into current Apr 25, 2023
@dbeatty10 dbeatty10 deleted the dbeatty/grants-redshift-groups branch April 25, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbeatty10 @mirnawong1