Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add run-operation command to run_results.json #3472

Merged
merged 9 commits into from
Jun 7, 2023
Merged

Add run-operation command to run_results.json #3472

merged 9 commits into from
Jun 7, 2023

Conversation

aranke
Copy link
Member

@aranke aranke commented Jun 5, 2023 •
edited
Loading

What are you changing in this pull request and why?

Adding run-operation to run_results.json; this was an oversight but will be fixed in dbt 1.6.

dbt-core merged PR: dbt-labs/dbt-core#7655

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@aranke
Add run-operation command to run_results.json
62635aa 
This will be true in dbt 1.6+
@aranke aranke requested a review from a team as a code owner June 5, 2023 17:12
@welcome
Copy link

welcome bot commented Jun 5, 2023

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@netlify
Copy link

netlify bot commented Jun 5, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit b6af189
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64806c6eda12d200088d76bd
😎 Deploy Preview https://deploy-preview-3472--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content new contributor Label for first-time contributors size: small This change will take 1 to 2 days to address labels Jun 5, 2023
runleonarun
runleonarun reviewed Jun 5, 2023
View reviewed changes
website/docs/reference/artifacts/run-results-json.md Outdated
@@ -5,7 +5,28 @@ sidebar_label: "Run results"

**Current schema**: [`v4`](https://schemas.getdbt.com/dbt/run-results/v4/index.html)

**Produced by:** [`build`](/reference/commands/build) [`compile`](/reference/commands/compile) [`docs generate`](/reference/commands/cmd-docs) [`seed`](/reference/commands/seed) [`snapshot`](/reference/commands/snapshot) [`test`](/reference/commands/test) [`run`](/reference/commands/run)
<VersionBlock lastVersion="1.6">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aranke I wonder if this should be 1.5? Otherwise both blocks might show up?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I wonder if you could version only the new command for 1.6 like this (which might make the code easier to read):

**Produced by:**
  [`build`](/reference/commands/build)
  [`compile`](/reference/commands/compile)
  [`docs generate`](/reference/commands/cmd-docs)
  [`run`](/reference/commands/run)
 <VersionBlock firstVersion="1.6"> [`run-operation`](/reference/commands/run-operation)</VersionBlock>
  [`seed`](/reference/commands/seed)
  [`snapshot`](/reference/commands/snapshot)
  [`test`](/reference/commands/test)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

Copy link
Contributor

@mirnawong1 mirnawong1 Jun 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to fix this as it's looking like this and snapshots, test, seeds don't appear correctly in v1.5 and lower.

Screenshot 2023-06-07 at 12 02 33

mirnawong1
mirnawong1 approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed versioning format and it's looking correct in the deploy preview, approving and merging

@mirnawong1
Copy link
Contributor

merging since this look correct

Screenshot 2023-06-07 at 13 12 43

@mirnawong1 mirnawong1 merged commit e520d80 into current Jun 7, 2023
@mirnawong1 mirnawong1 deleted the run_results_run_operation branch June 7, 2023 12:13
@mirnawong1
Copy link
Contributor

hey @aranke and @runleonarun, fyi i've merged this pr for ya'll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runleonarun runleonarun runleonarun left review comments

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aranke @mirnawong1 @runleonarun