Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resusable snippet for data platform pages #3541

Merged
merged 19 commits into from
Nov 20, 2023
Merged

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Jun 15, 2023

adding snippets to the dbt core data platform setups pages to pull in frontmatter content and reuse for headers and other content. (part 1 of a bigger task of organizing core data platform pages)

as part of references, changing setup pages and clarifying content so its more understandable and scalable.
@mirnawong1 mirnawong1 requested a review from a team as a code owner June 15, 2023 13:32
@netlify
Copy link

netlify bot commented Jun 15, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit f6ed283
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/649d96577169d20008cee831
😎 Deploy Preview https://deploy-preview-3541--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address labels Jun 15, 2023
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Jun 15, 2023
@mirnawong1 mirnawong1 mentioned this pull request Jun 16, 2023
7 tasks
@github-actions github-actions bot added size: large This change will more than a week to address and might require more than one person and removed size: medium This change will take up to a week to address labels Jun 16, 2023
@mirnawong1 mirnawong1 marked this pull request as draft June 26, 2023 08:58
@matthewshaver
Copy link
Contributor

Hi @mirnawong1 - This PR has been in draft for a few months. Given the changes we've made, do we want to fix the merge conflicts and move forward with this PR or close it and open an issue to address in the future?

@mirnawong1
Copy link
Contributor Author

Thanks again @matthewshaver ! Yep this is same thing with this pr discussed here -- it was deferred to post coalesce and was going to look at in nov. Happy to expedite so it doesn't block you!

@mirnawong1
Copy link
Contributor Author

going to go ahead and move forward with this pr and fix merge conflicts. picking this up early november

@mirnawong1 mirnawong1 closed this Oct 31, 2023
@mirnawong1 mirnawong1 reopened this Oct 31, 2023
@mirnawong1
Copy link
Contributor Author

going to fix ths pr up this week (nov 6th)

@mirnawong1 mirnawong1 marked this pull request as ready for review November 20, 2023 10:23
Copy link

vercel bot commented Nov 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 5:53pm

@mirnawong1 mirnawong1 changed the title clarify setup page content/headers add resusable snippet for data platform pages Nov 20, 2023
Copy link
Contributor

@dataders dataders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg this is incredible. i had forgotten that this was my dream. a year later and you deliver it! incredible!

next stop using pluggable snippets everywhere!!!

@mirnawong1 mirnawong1 merged commit aa79d4a into current Nov 20, 2023
7 checks passed
@mirnawong1 mirnawong1 deleted the mwong-parameters branch November 20, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: large This change will more than a week to address and might require more than one person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants