Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new state selectors #3596

Merged
merged 10 commits into from
Jul 6, 2023
Merged

Adding new state selectors #3596

merged 10 commits into from
Jul 6, 2023

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Adding the state:unmodified and state:old selectors

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@matthewshaver matthewshaver requested a review from a team as a code owner June 21, 2023 16:55
@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit b030eb9
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64a6f1c1441c490008d880d1
😎 Deploy Preview https://deploy-preview-3596--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Jun 21, 2023
@matthewshaver matthewshaver linked an issue Jun 21, 2023 that may be closed by this pull request
1 task
@jtcohen6
Copy link
Collaborator

jtcohen6 commented Jun 23, 2023

@matthewshaver dbt-labs/dbt-core#7773 hasn't been reviewed/merged yet — let's hold off on merging this docs update until we know when it will be released

Update: It's been merged! This PR is cleared for landing

Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! left one minor sugg

- `state:old` — A node with the same `unique_id` exists in the comparison manifest
- `state:unmodified` — All existing nodes with no changes

The primary benefit of these selectors is to exclude unchanged nodes to shorten run times. No subselectors are available at this time, but that may change as use cases evolve.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The primary benefit of these selectors is to exclude unchanged nodes to shorten run times. No subselectors are available at this time, but that may change as use cases evolve.
These selectors can help you shorten run times by excluding unchanged nodes. Currently, no subselectors are available at this time.

Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
@matthewshaver matthewshaver merged commit 1ab4799 into current Jul 6, 2023
9 checks passed
@matthewshaver matthewshaver deleted the new-state branch July 6, 2023 17:23
jtcohen6 added a commit that referenced this pull request Jul 18, 2023
resolves #3696
resolves #3723

Revise v1.6 migration guide for readability. Still a handful of TODOs.

### Materialized views
- Add `VersionBlock` components for adapter MVs, missed in
#3593
- We seem to be missing docs on Snowflake dynamic tables. I don't know
why #3494 was closed.

### Other updates
- Add manifest v10 (will need addition to schemas.getdbt.com:
dbt-labs/schemas.getdbt.com#24)
- Add note to upgrade guide for `state:old` and `state:unmodified`
(missed in #3596). I
haven't done a thorough comb-through of other closed v1.6 PRs to see
what needs addition to the migration guide.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update State Selection docs to add unmodified and old
3 participants