Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on model namespacing & uniqueness #3604

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

jtcohen6
Copy link
Collaborator

@jtcohen6 jtcohen6 commented Jun 22, 2023

resolves #3571

What are you changing in this pull request and why?

Starting in v1.6, model names can be duplicated across different namespaces (packages/projects). They must still be unique within one package/project.

This requires updates to:

  • our FAQ on model name uniqueness
  • two-argument ref
  • note on snapshot name uniqueness
  • (I'm sure I've missed some places)

Checklist

  • Add versioning components, as described in Versioning Docs
  • Add a note to the prerelease version Migration Guide
  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@jtcohen6 jtcohen6 requested a review from a team as a code owner June 22, 2023 12:16
@netlify
Copy link

netlify bot commented Jun 22, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 9548cb2
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/6494464a3b14060008464131
😎 Deploy Preview https://deploy-preview-3604--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: small This change will take 1 to 2 days to address labels Jun 22, 2023
@jtcohen6 jtcohen6 force-pushed the jerco/3571-model-namespacing branch from e6fe106 to 9548cb2 Compare June 22, 2023 13:02
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jtcohen6 jtcohen6 merged commit 4170337 into current Jun 26, 2023
@jtcohen6 jtcohen6 deleted the jerco/3571-model-namespacing branch June 26, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content guides Knowledge best suited for Guides size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespacing: models with same name across projects/packages
2 participants