-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to var, global macro resolution rules for package resources #3605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
content
Improvements or additions to content
guides
Knowledge best suited for Guides
size: medium
This change will take up to a week to address
labels
Jun 22, 2023
jtcohen6
force-pushed
the
jerco/3572-var-macro-namespacing
branch
from
June 22, 2023 13:05
b59ad2e
to
634dee7
Compare
1 task
Keeping consistent with style guide
Consistency
Changing perspective and formatting
matthewshaver
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
content
Improvements or additions to content
guides
Knowledge best suited for Guides
size: medium
This change will take up to a week to address
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3572
What are you changing in this pull request and why?
dispatch
, and linked to that new subsection fromgenerate_x_name
pagesThese are "quick hits," and very low-lying changes. For the people who have had to go deep on this stuff (package maintainers), I hope they're a big improvement to consistency/flexibility. I expect the vast majority of people to have no idea what these things mean.
Checklist
Uncomment if you're publishing docs for a prerelease version of dbt (delete if not applicable):