Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to var, global macro resolution rules for package resources #3605

Merged
merged 5 commits into from
Jun 28, 2023

Conversation

jtcohen6
Copy link
Collaborator

@jtcohen6 jtcohen6 commented Jun 22, 2023

resolves #3572

What are you changing in this pull request and why?

These are "quick hits," and very low-lying changes. For the people who have had to go deep on this stuff (package maintainers), I hope they're a big improvement to consistency/flexibility. I expect the vast majority of people to have no idea what these things mean.

Checklist

Uncomment if you're publishing docs for a prerelease version of dbt (delete if not applicable):

  • Add versioning components, as described in Versioning Docs
  • Add a note to the prerelease version Migration Guide
  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@jtcohen6 jtcohen6 requested a review from a team as a code owner June 22, 2023 12:50
@netlify
Copy link

netlify bot commented Jun 22, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit b2ffb18
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/649b4a14e6fa3800081b670a
😎 Deploy Preview https://deploy-preview-3605--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: medium This change will take up to a week to address labels Jun 22, 2023
@jtcohen6 jtcohen6 force-pushed the jerco/3572-var-macro-namespacing branch from b59ad2e to 634dee7 Compare June 22, 2023 13:05
Keeping consistent with style guide
Copy link
Contributor

@matthewshaver matthewshaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you!

@jtcohen6 jtcohen6 merged commit cab7a3f into current Jun 28, 2023
@jtcohen6 jtcohen6 deleted the jerco/3572-var-macro-namespacing branch June 28, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content guides Knowledge best suited for Guides size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespacing: scope & resolution changes for vars & macros
2 participants