Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update post-hook for "latest" model version #3652

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Update post-hook for "latest" model version #3652

merged 2 commits into from
Jul 4, 2023

Conversation

jtcohen6
Copy link
Collaborator

This is still just a placeholder "YMMV" solution until we decide on a real implementation:

If you're versioning some_model for the first time:

  • that model is materialized as a table
  • my_db.my_schema.some_model will exist as a table in the database
  • needs to be dropped before running create or replace view

(NOTE: I need to actually test this code)

@jtcohen6
Update post-hook for "latest" model version
4e19710 
This is still just a placeholder "YMMV" solution until we decide on a real implementation:
- dbt-labs/dbt-core#7442
@jtcohen6 jtcohen6 requested a review from a team as a code owner June 30, 2023 13:22
@netlify
Copy link

netlify bot commented Jun 30, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit d7b1963
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64a4a947a5f39e00085a29cc
😎 Deploy Preview https://deploy-preview-3652--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jun 30, 2023
@jtcohen6 jtcohen6 added the dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) label Jun 30, 2023
@jtcohen6 jtcohen6 added this to the dbt Core v1.5 Documentation milestone Jun 30, 2023
@jtcohen6 jtcohen6 requested review from joellabes and dbeatty10 July 4, 2023 09:01
joellabes
joellabes approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just worked on my branch and looks good, so let's do it :shipit:

@joellabes joellabes enabled auto-merge (squash) July 4, 2023 23:20
@joellabes joellabes merged commit ca60019 into current Jul 4, 2023
@joellabes joellabes deleted the jerco/update-model-version-create-latest-post-hook branch July 4, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joellabes joellabes joellabes approved these changes

@dbeatty10 dbeatty10 Awaiting requested review from dbeatty10

Assignees
No one assigned
Labels
content Improvements or additions to content dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
dbt Core v1.5 Documentation
Development

Successfully merging this pull request may close these issues.
2 participants
@jtcohen6 @joellabes