-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate crawler #4385
Automate crawler #4385
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Check your created Crawler Check your created index on your Algolia Application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @JKarlavige ! this looks good to me - i couldn't test this out in this pr but the testing you provided looks amazing! thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Confirmed opening a PR on the sandbox repo and tagging with trigger-crawl
will initiate a crawl after the build has completed.
Will go ahead and merge this. If all works as expected a crawl should be triggered after this production build is complete! |
What are you changing in this pull request and why?
Asana task
Adds Git workflow to trigger an Algolia crawl on PR merges.
To trigger the crawler, add the
trigger-crawl
label to a PR. Once the PR is merged, the GitHub Action will:trigger-crawl
label is setExample run from this PR
Web Team Testing
To test:
trigger-crawl
label set.Notes
Rather than using the
sleep 480
command to wait 8 minutes before triggering the crawl, I looked into using this git action to watch for a Vercel deployment. However, this watches for preview deploys, so if a previous deploy preview was built from an earlier commit, this step will complete instantly and will allow the crawl to start before the live docs site is rebuilt.There's another git action for watching Vercel deployments. However their section on dynamically resolving a deployment URL has an example workflow which i'd rather not do due to the complexity of it.