add cycle detection info #4398
Merged
add cycle detection info #4398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding cycle detection link per slack feedback
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
Docs team
mirnawong1
commented
Nov 3, 2023
website/docs/guides/best-practices/how-we-mesh/mesh-2-structures.md
Outdated
Show resolved
Hide resolved
mirnawong1
commented
Nov 3, 2023
| @@ -18,6 +18,10 @@ At a high level, you’ll need to decide: | |||
| - Where to draw the lines between your dbt Projects -- i.e. how do you determine where to split your DAG and which models go in which project? | |||
| - How to manage your code -- do you want multiple dbt Projects living in the same repository (mono-repo) or do you want to have multiple repos with one repo per project? | |||
|
|
|||
| ### Cycle detection | |||
|
|
|||
| Currently, project dependencies only work in a one-way direction. This helps you avoid indefinite project `ref` cycles (or loops) and issues with your data workflows. For example, the `jaffle_finance"` project can't introduce a new model that depends on `jaffle_marketing.roi_by_channel`. Refer to [Project dependencies](/docs/collaborate/govern/project-dependencies#how-to-use-ref) for more information. | |||
There was a problem hiding this comment.
Suggested change
| Currently, project dependencies only work in a one-way direction. This helps you avoid indefinite project `ref` cycles (or loops) and issues with your data workflows. For example, the `jaffle_finance"` project can't introduce a new model that depends on `jaffle_marketing.roi_by_channel`. Refer to [Project dependencies](/docs/collaborate/govern/project-dependencies#how-to-use-ref) for more information. | |
| Currently, project dependencies only work in a one-way direction. This helps you avoid indefinite project `ref` cycles (or loops) and also avoid issues with your data workflows. For example, the `jaffle_finance"` project can't introduce a new model that depends on `jaffle_marketing.roi_by_channel`. Refer to [Project dependencies](/docs/collaborate/govern/project-dependencies#how-to-use-ref) for more information. |
There was a problem hiding this comment.
adding avoid twice because i feel the 2nd issue gets lost. might be overthinking it
website/docs/guides/best-practices/how-we-mesh/mesh-2-structures.md
Outdated
Show resolved
Hide resolved
…es.md Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
matthewshaver
approved these changes
Nov 3, 2023
runleonarun
approved these changes
Nov 3, 2023
| @@ -18,6 +18,10 @@ At a high level, you’ll need to decide: | |||
| - Where to draw the lines between your dbt Projects -- i.e. how do you determine where to split your DAG and which models go in which project? | |||
| - How to manage your code -- do you want multiple dbt Projects living in the same repository (mono-repo) or do you want to have multiple repos with one repo per project? | |||
|
|
|||
| ### Cycle detection | |||
|
|
|||
| Currently, project dependencies only work in a one-way direction. This helps you avoid indefinite project `ref` cycles (or loops) and issues with your data workflows. For example, the `jaffle_finance"` project can't introduce a new model that depends on `jaffle_marketing.roi_by_channel`. Refer to [Project dependencies](/docs/collaborate/govern/project-dependencies#how-to-use-ref) for more information. | |||
There was a problem hiding this comment.
I see a stray " here:
jaffle_finance"
There was a problem hiding this comment.
thank you good catch! i think @matthewshaver caught it too 🙏
dave-connors-3
previously requested changes
Nov 3, 2023
| @@ -18,6 +18,10 @@ At a high level, you’ll need to decide: | |||
| - Where to draw the lines between your dbt Projects -- i.e. how do you determine where to split your DAG and which models go in which project? | |||
| - How to manage your code -- do you want multiple dbt Projects living in the same repository (mono-repo) or do you want to have multiple repos with one repo per project? | |||
|
|
|||
| ### Cycle detection | |||
|
|
|||
| Currently, project dependencies only work in a one-way direction. This helps you avoid indefinite project `ref` cycles (or loops) and issues with your data workflows. For example, the `jaffle_finance"` project can't introduce a new model that depends on `jaffle_marketing.roi_by_channel`. Refer to [Project dependencies](/docs/collaborate/govern/project-dependencies#how-to-use-ref) for more information. | |||
There was a problem hiding this comment.
I think since we don't mention the jaffle projects until page 3, we shouldn't bring them up here!
Suggested change
| Currently, project dependencies only work in a one-way direction. This helps you avoid indefinite project `ref` cycles (or loops) and issues with your data workflows. For example, the `jaffle_finance"` project can't introduce a new model that depends on `jaffle_marketing.roi_by_channel`. Refer to [Project dependencies](/docs/collaborate/govern/project-dependencies#how-to-use-ref) for more information. | |
| Like resource dependencies, project dependencies are acyclic, meaning they only move in one direction. This prevents `ref` cycles (or loops), which lead to issues with your data workflows. For example, if project B depends on project A, a new model in project A could not import and use a public model from project B. Refer to [Project dependencies](/docs/collaborate/govern/project-dependencies#how-to-use-ref) for more information. |
mirnawong1
commented
Nov 3, 2023
website/docs/guides/best-practices/how-we-mesh/mesh-2-structures.md
Outdated
Show resolved
Hide resolved
matthewshaver
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding cycle detection link per slack feedback