Update metricflow-commands.md #4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarify mf command examples avail in cloud
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
|
hey @WilliamDee - does this look right to you? 🙏 |
WilliamDee
approved these changes
Nov 10, 2023
website/docs/guides/best-practices/how-we-build-our-metrics/semantic-layer-4-build-metrics.md
Show resolved
Hide resolved
| @@ -180,9 +180,9 @@ Options: | |||
| ### Validate-configs | |||
|
|
|||
| This command performs validations against the defined semantic model configurations: | |||
| <!--dbt sl validate-configs # In dbt Cloud--> | |||
There was a problem hiding this comment.
This is redundant for now since as you can run a manifest generating command (dbt parse/build/compile/run) https://docs.getdbt.com/docs/dbt-cloud-apis/sl-manifest#how-its-produced and it would already have done the validations and if that step fails with something about the SL config it means the validations failed.
|
thank you @WilliamDee ! i will tackle your comments in a separate pr to get this cleaned up! |
Merged
mirnawong1
added a commit
that referenced
this pull request
Nov 13, 2023
folding in @WilliamDee's feedback from #4426
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clarify mf command examples avail in cloud