Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation on yml version defaults #5672

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

LeoTheGriff
Copy link
Contributor

@LeoTheGriff LeoTheGriff commented Jun 18, 2024

What are you changing in this pull request and why?

The config-version documentation is not clear about what the default value is. It states that the parameter is optional and that the old version, version 1, is not in use. This implies that the default version should be 2, but the default is explicitly stated here as version 1.

## Default
Without this configuration, dbt will assume your dbt_project.yml uses the version 1 syntax, which was deprecated in dbt v0.19.0.

As per PR dbt-labs/dbt-core#7060, the default version is in-fact version 2, so this documentation needs to be updated.

Checklist

Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 9:37am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jun 18, 2024
@LeoTheGriff LeoTheGriff marked this pull request as ready for review June 18, 2024 14:00
@LeoTheGriff LeoTheGriff requested a review from a team as a code owner June 18, 2024 14:00
@LeoTheGriff
Copy link
Contributor Author

I assume the PRs that are failing are to do with managing PRs, not to functionality. Please let me know if any actions are required from me.

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @LeoTheGriff , great catch! you're absolutely right and i like your re-wording! will get this merged for you - looking forward to your future contributions ✨ many thanks for opening this up :D

@mirnawong1 mirnawong1 merged commit 0ac7d57 into dbt-labs:current Jun 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants