-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Roadmap] Custom version name functionality #5974
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
size: medium
This change will take up to a week to address
label
Aug 26, 2024
matthewshaver
approved these changes
Aug 27, 2024
JKarlavige
changed the title
Custom version name functionality
[Roadmap] Custom version name functionality
Aug 27, 2024
john-rock
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
Asana task
Adds a
customDisplay
property to theversions
object to provide the option of setting a custom display name for a specific version.For example, we can show
dbt Cloud
rather thanv1.9
by setting the version inwebsite/dbt-versions.js
:Preview
https://docs-getdbt-com-git-custom-version-name-dbt-labs.vercel.app
Notes
Disregard the
v1.9
banner, this only shows because I set thecustomDisplay
property on a version which is usingisPrerelease
. Confirmed with Matt they will create a separate version to use thecustomDisplay
property which doesn't use theisPrerelease
flag in prod, and the banner will not show in that scenario.TODO Before Merge