consolidate excel gsheets #5977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
rpourzand
reviewed
Aug 27, 2024
| <!-- this comment explains the following: | ||
| 1. uses the /snippets/_sl-excel-gsheets.md snippet file to render gsheets and excel content since they're similar | ||
| 2. removes the below content (tip and using saved queries header) so it's not duplicative. removing the below content fully a month or so after the launch. | ||
| 3. keep tje limited policy section in gsheets only and do not add to the /snippets/_sl-excel-gsheets.md snippet file. |
There was a problem hiding this comment.
Hiya @mirnawong1
This is a non-blocker (I think) as it appears to have been removed, but I wasn't able to find this section (lines 48 - 51) on the staging preview page).
Kind Regards
Natalie
nataliefiann
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Hiya @mirnawong1
Thank you for creating this PR - it's great! I left a comment but I think it may have already been resolved (but thought i'd raise it just in case I missed it). Other than that, there are no suggestions or recommendations from me.
Kind Regards
|
merging once i get the final ok from @rpourzand or @Jstein77 |
|
Check your created Crawler Check your created index on your Algolia Application |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds saved queries and saved selection support for the SL excel integration.
it also consolidates the excel and gsheets content into one snippet