Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloud to version dropdown #5985

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Add Cloud to version dropdown #5985

merged 4 commits into from
Aug 28, 2024

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Adding dbt Cloud (Versionless) to version dropdown.

This is a cosmetic change only.

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@matthewshaver matthewshaver requested a review from a team as a code owner August 28, 2024 15:45
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Aug 28, 2024 5:11pm

@github-actions github-actions bot added Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. labels Aug 28, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! non blocker but i'm not sure if it looks cleaner if it's just 'dbt Cloud Versionless'. but either is great!

the bigger thing I've noticed is that if i select dbt Cloud (Versionless) in the dropdown, some pages (like build your metrics, retry, or contract disappear, along with any version blocks associated. i also see the 'this feature isn't available in dbt core version 1.10, yo ushoudl upgrade to..' banner. not sure if we want that for this experience?

it looks like for those examples, they're listed in the dbt-versions.js file so is there a discrepancy in what the dbt-versions.js file has listed and the `customDisplay for 1.10?

@matthewshaver
Copy link
Contributor Author

Figured out that v1.10 is seen as less than v1.2-1.9, so that caused pages to disappear.
The config file respects semantic versioning so will use that until we have a chance to fix the behavior.
Shortened the name to prevent spacing issues

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it again and looks great to me! thank you so much @JKarlavige and @matthewshaver - rockstar team!

@matthewshaver matthewshaver merged commit 4689936 into current Aug 28, 2024
10 checks passed
@matthewshaver matthewshaver deleted the add-cloud-docs branch August 28, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants