-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cloud to version dropdown #5985
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great! non blocker but i'm not sure if it looks cleaner if it's just 'dbt Cloud Versionless'. but either is great!
the bigger thing I've noticed is that if i select dbt Cloud (Versionless) in the dropdown, some pages (like build your metrics, retry, or contract disappear, along with any version blocks associated. i also see the 'this feature isn't available in dbt core version 1.10, yo ushoudl upgrade to..' banner. not sure if we want that for this experience?
it looks like for those examples, they're listed in the dbt-versions.js
file so is there a discrepancy in what the dbt-versions.js file has listed and the `customDisplay for 1.10?
Figured out that v1.10 is seen as less than v1.2-1.9, so that caused pages to disappear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested it again and looks great to me! thank you so much @JKarlavige and @matthewshaver - rockstar team!
What are you changing in this pull request and why?
Adding dbt Cloud (Versionless) to version dropdown.
This is a cosmetic change only.
Checklist
Adding or removing pages (delete if not applicable):
website/sidebars.js
website/vercel.json
npm run build
to update the links that point to deleted pages