Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced CI #5987

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Advanced CI #5987

merged 6 commits into from
Aug 29, 2024

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Adding advanced CI data storage information

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@matthewshaver matthewshaver requested a review from a team as a code owner August 28, 2024 20:44
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Aug 29, 2024 2:14pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Aug 28, 2024
Copy link

@reubenmc reubenmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


Advanced CI helps developers answer the question, “Will this PR build the correct changes in production?” By demonstrating the data changes that code changes produce, users can ensure they always ship trusted data products as they develop.

Customers control what data to use and may implement synthetic data if pre-production or development data is heavily regulated or sensitive. The data clients choose only persists on dbt Labs systems for up to 30 days. dbt Labs does not access Advanced CI cached data for its benefit, and the data is only used to provide services to clients as they direct. This caching optimizes compute usage so that the entire comparison is not rerun against the data warehouse each time the **Compare** tab is viewed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change "The data clients choose only persists on dbt Labs systems for up to 30 days." to "The data clients choose is cached on dbt Labs systems for up to 30 days."

Rereading this I realized that the reference is caching in the last sentence here doesn't make sense without mentioning it first.

description: "Advanced CI enables developers to compare changes by demonstrating the changes the code produces."
---

Advanced CI helps developers answer the question, “Will this PR build the correct changes in production?” By demonstrating the data changes that code changes produce, users can ensure they always ship trusted data products as they develop.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

matthewshaver and others added 3 commits August 29, 2024 09:55
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
@matthewshaver matthewshaver merged commit 932ff42 into current Aug 29, 2024
10 checks passed
@matthewshaver matthewshaver deleted the advanced-ci branch August 29, 2024 14:17
Copy link
Contributor

Check your created Crawler

Check your created index on your Algolia Application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address trigger-crawl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants