Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct how to get tags at the model level to work. #5988

Closed
wants to merge 3 commits into from

Conversation

alison985
Copy link
Contributor

What are you changing in this pull request and why?

In version 1.8 both of these parse/compile.

Syntax currently in docs:

models:
  - name: apples
    config:
      - tags: ['fruit']

Syntax I'm changing it to in this PR:

models: 
  - name: apples
    tags: ['fruit']

If you do model > config > tags then they don't show up in the dbt docs page for the model. You have to use model > tags directly for them to be found.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • [n/a] The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • Review at least the rest of the tags.md page to see if any other locations need to be updated.

@alison985 alison985 requested a review from a team as a code owner August 29, 2024 01:16
Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Sep 3, 2024 9:44am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Aug 29, 2024
@mirnawong1
Copy link
Contributor

mirnawong1 commented Sep 3, 2024

hey @alison985 , thanks so much for raising this and opening up the PR! I've consulted with @joellabes and it seems like, historically, tags are allowed to be put inside or outside of the config block so this doesn't sound like expected behavior. it could be a bug in dbt docs -- do you mind opening an issue in the dbt core repo for further investigation?

will close this pr out but happen to reopen if things change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants