Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a text in docs to prevent using -- for comment. #6006

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

woraperth
Copy link
Contributor

@woraperth woraperth commented Sep 4, 2024

The error message (local variable 'connection' referenced before assignment) when using -- doesn't indicate the actual syntax error. It is also not documented

What are you changing in this pull request and why?

Stumbled upon error from this issue and tried to debug it for few hours until I realised this error. Adding text in the docs to prevent other developers finding the same issue.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

The error message (local variable 'connection' referenced before assignment) when using `--` doesn't indicate the actual syntax error. It is also not documented
@woraperth woraperth requested a review from a team as a code owner September 4, 2024 04:29
Copy link

welcome bot commented Sep 4, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Sep 4, 2024

@woraperth is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@runleonarun runleonarun added the new contributor Label for first-time contributors label Sep 4, 2024
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. and removed new contributor Label for first-time contributors labels Sep 4, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @woraperth , great callout and thank you so much for adding this to the docs and looking out for other developers! looks great and merging for you!

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Sep 5, 2024 9:07am

@mirnawong1 mirnawong1 enabled auto-merge (squash) September 5, 2024 09:01
@mirnawong1 mirnawong1 merged commit 4d1591c into dbt-labs:current Sep 5, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants