Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needs PM review - update data health tile #6018

Merged
merged 7 commits into from
Sep 6, 2024
Merged

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Sep 5, 2024

After PM sync, updated data health tile doc to make it clearer users can embed data health tile url or iframe in any tool. turn tableau into example.

[ ] Needs PM review

@mirnawong1 mirnawong1 requested a review from a team as a code owner September 5, 2024 10:13
Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Sep 6, 2024 9:04am

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address labels Sep 5, 2024
@mirnawong1 mirnawong1 changed the title update data health tile needs PM review - update data health tile Sep 5, 2024
Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

Thank for creating this PR - it's great!
I made a small typo correction (added a full stop) and also made a non-blocking suggestion. Other than that, I have no comments / suggestions. I've approved this for you.

Kind Regards

Copy link
Contributor

@rpourzand rpourzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mirnawong1 mirnawong1 enabled auto-merge (squash) September 6, 2024 09:00
@mirnawong1 mirnawong1 merged commit 6a1a7bc into current Sep 6, 2024
10 checks passed
@mirnawong1 mirnawong1 deleted the update-health-tile branch September 6, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants