update ip doc and add clarification #6020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
mirnawong1
commented
Sep 5, 2024
nataliefiann
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Hiya @mirnawong1
Thanks for creating this PR - it's a really good read! I have left one non-blocking suggestion / question but other than that I have no other comments or recommendations and approved this for you.
Kind Regards
| Note that simply adding the IP Ranges will not enforce IP restrictions. For more information, see the section “Enabling Restrictions.” | ||
| Add multiple IP ranges by clicking the **Add IP range** button to create a new text field. | ||
|
|
||
| Note that simply adding the IP Ranges will not enforce IP restrictions. For more information, see the [Enabling restrictions](#enabling-restrictions) section. |
There was a problem hiding this comment.
Hiya @mirnawong1
This is a non-blocking suggestion, but do you think it'd be worth adding a sentence advising why adding an IP range won't enforce IP restrictions?
Kind Regards
There was a problem hiding this comment.
good quesiton and feedback @nataliefiann ! looping @matthewshaver to address that question since he's the some and it's outside the scope of this pr!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the IP restrictions doc and addresses the issues raised in #5727.
Resolves #5727