Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clone and docs generate to list of commands retry supports. #6095

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

jordivandooren
Copy link
Contributor

What are you changing in this pull request and why?

clone and docs generate were never included in the lists of commands that retry support, but it seems like both commands have been supported since the dbt 1.6 release that introduced dbt retry.

See https://github.com/dbt-labs/dbt-core/blob/main/core/dbt/task/retry.py.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

`clone` and `docs generate` were never included in the lists of commands that `retry` support, but it seems like both commands have been supported since the dbt 1.6 release that introduced `dbt retry`. 

See https://github.com/dbt-labs/dbt-core/blob/main/core/dbt/task/retry.py.
@jordivandooren jordivandooren requested a review from a team as a code owner September 19, 2024 10:11
Copy link

vercel bot commented Sep 19, 2024

@jordivandooren is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Sep 19, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch @jordivandooren ! thanks so much for linking this and creating a pr to fix this up!

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Sep 19, 2024 11:25am

@mirnawong1 mirnawong1 merged commit 52db5af into dbt-labs:current Sep 19, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants