Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clearer that the redirect url needs to be updated #6099

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

b-per
Copy link
Contributor

@b-per b-per commented Sep 19, 2024

What are you changing in this pull request and why?

Right now, the docs are not really clear that the OAUTH_REDIRECT_URI parameter needs to be updated with the value gotten from before.

We list 'LOCATED_REDIRECT_URI' (which people need to update), like we list 'CONFIDENTIAL' which is a fixed string.

Checklist

@b-per b-per requested a review from a team as a code owner September 19, 2024 12:35
Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Sep 20, 2024 8:17am

@github-actions github-actions bot added the content Improvements or additions to content label Sep 19, 2024
@b-per b-per requested review from Lana-hl and removed request for a team September 19, 2024 12:35
@github-actions github-actions bot added the size: x-small This change will take under 3 hours to fix. label Sep 19, 2024
@mirnawong1
Copy link
Contributor

hey @b-per and @Lana-hl - thanks for working together on this! I'm going to tweak this to make it further clear bc you're totally right! and i also think that tags <> aren't always understood as 'replace'.

also, in the previous text we say: In the following example create or replace security integration query, replace YOUR_ACCESS_URL with the appropriate Access URL for your region and plan.'

but i don't see any reference to access URL?

CREATE OR REPLACE SECURITY INTEGRATION DBT_CLOUD
  TYPE = OAUTH
  ENABLED = TRUE
  OAUTH_CLIENT = CUSTOM
  OAUTH_CLIENT_TYPE = 'CONFIDENTIAL'
  OAUTH_REDIRECT_URI = 'LOCATED_REDIRECT_URI'
  OAUTH_ISSUE_REFRESH_TOKENS = TRUE
  OAUTH_REFRESH_TOKEN_VALIDITY = 7776000;

@Lana-hl
Copy link
Contributor

Lana-hl commented Sep 19, 2024

great point @mirnawong1 ! I do think it will make it clearer if we add back the [appropriate Access URL](https://docs.getdbt.com/docs/cloud/about-cloud/access-regions-ip-addresses) for your region and plan part

@mirnawong1
Copy link
Contributor

mirnawong1 commented Sep 19, 2024

hey @b-per and @Lana-hl , how's this looking for you both: preview link. we could remove the comment in the code if it's tmi

Screenshot 2024-09-19 at 14 03 50

@b-per
Copy link
Contributor Author

b-per commented Sep 19, 2024

I might recommend removing the comment because I don't know if the statement would work with it.

Nitpicking a bit, I think that LOCATED_REDIRECT_URI is an odd name to the parameter as well, but I don't really mind if we don't change it.

@mirnawong1
Copy link
Contributor

ok i've updated it to this and added a screenshot that @Lana-hl provided:
Screenshot 2024-09-19 at 15 21 22

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Sep 19, 2024
@mirnawong1
Copy link
Contributor

hey @b-per @Lana-hl , going to merge this pr now. let me know if you have any issues or other thoughts - will be happy to address in another pr! thank you again for the help!

@mirnawong1 mirnawong1 merged commit 3578cfe into current Sep 20, 2024
5 of 6 checks passed
@mirnawong1 mirnawong1 deleted the b-per-patch-1 branch September 20, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants