Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated constraints doc to include the new recommended syntax #6105

Closed
wants to merge 48 commits into from

Conversation

nataliefiann
Copy link
Contributor

@nataliefiann nataliefiann commented Sep 20, 2024

What are you changing in this pull request and why?

closes #5983

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

I have created this pull request following Git issue: #5983 raised by Jerco which discusses the new recommended syntax for foreign keys.

@nataliefiann nataliefiann requested a review from a team as a code owner September 20, 2024 11:07
Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Sep 30, 2024 9:27am

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Sep 20, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @nataliefiann , have some suggestions and feedback on the layout/versioning! great job doing your first (or one of your first) versionblocks!

let me know what you think!

nataliefiann and others added 7 commits September 20, 2024 13:28
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
@mirnawong1
Copy link
Contributor

thanks @nataliefiann ! have reviewed and added some comments:

  • whether we should just versionblock the actual changes and not content that applies to both
  • double check the improved syntax yaml because the indentation is a bit off
  • do we want to add a release note as mentioned by @jtcohen6 here

Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @nataliefiann , looks good! i took the liberty to update the yaml code directly and added models at the starting point so it's consistent and adjusted the formatting.

have approved it for you, however not sure if you're waiting for @jtcohen6 to take a look!

Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
@jtcohen6
Copy link
Collaborator

jtcohen6 commented Oct 1, 2024

@nataliefiann Thank you for getting this started!

I'm going to close this PR in favor of #6189

@nataliefiann
Copy link
Contributor Author

Closed off as Core project has been paused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Foreign key constraints support to (with ref) + to_columns
3 participants