-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated constraints doc to include the new recommended syntax #6105
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @nataliefiann , have some suggestions and feedback on the layout/versioning! great job doing your first (or one of your first) versionblocks!
let me know what you think!
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
thanks @nataliefiann ! have reviewed and added some comments: |
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @nataliefiann , looks good! i took the liberty to update the yaml code directly and added models
at the starting point so it's consistent and adjusted the formatting.
have approved it for you, however not sure if you're waiting for @jtcohen6 to take a look!
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
@nataliefiann Thank you for getting this started! I'm going to close this PR in favor of #6189 |
Closed off as Core project has been paused |
What are you changing in this pull request and why?
closes #5983
Checklist
I have created this pull request following Git issue: #5983 raised by Jerco which discusses the new recommended syntax for foreign keys.