Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing banners #6109

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Removing banners #6109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions website/src/theme/DocRoot/Layout/Main/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,16 @@
version: dbtVersion,
EOLDate,
isPrerelease,
latestStableRelease,

Check warning on line 43 in website/src/theme/DocRoot/Layout/Main/index.js

View workflow job for this annotation

GitHub Actions / eslint-check 

'latestStableRelease' is assigned a value but never used
} = useContext(VersionContext);

const {
pageAvailable,

Check warning on line 47 in website/src/theme/DocRoot/Layout/Main/index.js

View workflow job for this annotation

GitHub Actions / eslint-check 

'pageAvailable' is assigned a value but never used
firstAvailableVersion,
lastAvailableVersion

Check warning on line 49 in website/src/theme/DocRoot/Layout/Main/index.js

View workflow job for this annotation

GitHub Actions / eslint-check 

'lastAvailableVersion' is assigned a value but never used
} = pageVersionCheck(dbtVersion, versionedPages, currentDocRoute);

const hasFirstAvailableVersion =

Check warning on line 52 in website/src/theme/DocRoot/Layout/Main/index.js

View workflow job for this annotation

GitHub Actions / eslint-check 

'hasFirstAvailableVersion' is assigned a value but never used
firstAvailableVersion && firstAvailableVersion !== "0";

// Check whether this version is a isPrerelease, and show banner if so
Expand Down Expand Up @@ -119,34 +119,6 @@
hiddenSidebarContainer && styles.docItemWrapperEnhanced
)}
>
{!pageAvailable &&
dbtVersion && (
<div className={styles.versionBanner}>
<Admonition
type="caution"
title={`${hasFirstAvailableVersion ? "New feature!" : lastAvailableVersion ? "Old feature" : "Note"}`}
icon={
hasFirstAvailableVersion
? "🎉"
: lastAvailableVersion
? "❗"
: ""
}
>
<p style={{ marginTop: "5px", marginBottom: "0" }}>
Unfortunately, this feature is not available in dbt Core
version {dbtVersion}
</p>
{hasFirstAvailableVersion ? (
<p>
{" "}
You should upgrade to {firstAvailableVersion} or later if
you want to use this feature.
</p>
) : null}
</Admonition>
</div>
)}
{PreData.showisPrereleaseBanner && (
<div className={styles.versionBanner}>
<Admonition type="caution" title="Warning">
Expand Down
Loading