Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick edits to 2025-01-24-sql-comprehension-technologies.md #6831

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

coapacetic
Copy link
Contributor

What are you changing in this pull request and why?

Heya Dave and team! Excellent writing and teaching here! I was doing some late night reading catching up on my database technology and compilers and learned a lot. Thank you!

Contributing back a small token of appreciation with some quick spelling and grammar tweaks as my own mind compiles (parses and binds) the text in the post.

I also noticed there was a part where the post references a diagram that was not showing up on mobile when I read it. Here is the text to track it down in the markdown, "The diagram below shows the entire process of compilation."

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.
  • Add in the reference diagram about the full compilation step after the sentence "The diagram below shows the entire process of compilation."

@coapacetic coapacetic requested a review from a team as a code owner January 25, 2025 03:54
Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jan 25, 2025 2:55pm

@github-actions github-actions bot added developer blog This content fits on the developer blog. size: small This change will take 1 to 2 days to address labels Jan 25, 2025
@coapacetic
Copy link
Contributor Author

Tagged in @dave-connors-3 in case you have the diagram on hand 🙌

Copy link
Contributor

@dave-connors-3 dave-connors-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appreciate you coap

@dave-connors-3
Copy link
Contributor

@coapacetic i think we ended up killing that diagram and moving it up, so not only could you not see it on mobile, there was nothing there at all! removed that sentence!

@dave-connors-3 dave-connors-3 merged commit 64efb00 into current Jan 25, 2025
7 checks passed
@dave-connors-3 dave-connors-3 deleted the coapacetic-patch-7 branch January 25, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer blog This content fits on the developer blog. size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants