Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snapshots.md to clarify folder location #6840

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Update snapshots.md to clarify folder location #6840

merged 3 commits into from
Jan 28, 2025

Conversation

faithebear
Copy link
Contributor

@faithebear faithebear commented Jan 28, 2025 •
edited by github-actions bot
Loading

What are you changing in this pull request and why?

Snapshot can still get run if they are in the models or snapshots directory! I added a line in the docs to clarify this.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

@faithebear
Update snapshots.md
701238a 
snapshots don't have to go in the snapshots folder now
@faithebear faithebear requested a review from a team as a code owner January 28, 2025 18:16
@vercel Vercel
Copy link

vercel bot commented Jan 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jan 28, 2025 7:01pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jan 28, 2025
mirnawong1
mirnawong1 approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mirnawong1
Copy link
Contributor

looks great @faithebear ! thank you! also addressing the snapshot location in this pr here https://github.com/dbt-labs/docs.getdbt.com/pull/6803/files# that's going to be checked out by @joellabes

@mirnawong1 mirnawong1 enabled auto-merge January 28, 2025 18:56
@mirnawong1 mirnawong1 merged commit 3fbe8c3 into current Jan 28, 2025
8 checks passed
@mirnawong1 mirnawong1 deleted the faith-snapshots branch January 28, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faithebear @mirnawong1