Skip to content

Commit

Permalink
Merge pull request #56 from dbt-labs/use_gh_actions
Browse files Browse the repository at this point in the history
  • Loading branch information
aranke authored May 4, 2023
2 parents d4e1101 + 0c13cdb commit 98c1719
Show file tree
Hide file tree
Showing 3 changed files with 67 additions and 106 deletions.
104 changes: 0 additions & 104 deletions .circleci/config.yml

This file was deleted.

67 changes: 67 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
# **what**: linting (black, mypy) and testing (pytest) workflows for Hologram
# **why**: to ensure that the code is formatted correctly and that it passes all tests
# **when**: on every push to main and every pull request
name: CI

on:
push:
branches:
- main
pull_request:
branches:
- '**'

jobs:
lint:
runs-on: ubuntu-latest

steps:
- name: Checkout repository
uses: actions/checkout@v3

- name: Set up Python 3.9
uses: actions/setup-python@v4
with:
python-version: 3.9

- name: Install dependencies
run: |
python -m venv venv
source venv/bin/activate
pip install . black mypy
- name: Check code formatting
run: |
source venv/bin/activate
black --check hologram/ tests/
- name: Run mypy
run: |
source venv/bin/activate
mypy hologram --ignore-missing-imports
test:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11']

steps:
- name: Checkout repository
uses: actions/checkout@v3

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}

- name: Install dependencies
run: |
python -m venv venv
source venv/bin/activate
pip install . pytest
- name: Run tests
run: |
source venv/bin/activate
pytest
2 changes: 0 additions & 2 deletions hologram/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,6 @@ def encoder(ft, val, o):
# TODO: is there some way to set __args__ on this so it can
# just re-use Dict/Mapping?
def encoder(ft, val, o):

return {
cls._encode_field(str, k, o): cls._encode_field(
ft.TARGET_TYPE, v, o
Expand Down Expand Up @@ -740,7 +739,6 @@ def _get_schema_for_type(
required: bool = True,
restrictions: Optional[List[Any]] = None,
) -> Tuple[JsonDict, bool]:

field_schema: JsonDict = {"type": "object"}

type_name = cls._get_field_type_name(target)
Expand Down

0 comments on commit 98c1719

Please sign in to comment.