Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest v12 with dbt-core@main as of 2024.05.01 #37

Merged
merged 2 commits into from
May 2, 2024

Conversation

jtcohen6
Copy link
Collaborator

@jtcohen6 jtcohen6 commented May 2, 2024

Regenerate manifest for all changes from the past few months (since 9 February). This includes substantial renaming and reorganization of the "resource" classes that we tackled as part of:

@jtcohen6 jtcohen6 requested a review from aranke May 2, 2024 11:09
@aranke
Copy link
Member

aranke commented May 2, 2024

Quick inspection looks good to me, see manifest_diff.txt.

Apart from most of the changes on additionalProperties, the following have changed:

  1. dbt_version: 1.8.0a11.8.0b3
  2. metrics.properties now supports meta
  3. saved_query.database is a new nullable string field
  4. _event_status is no longer a field in additionalProperties
  5. unit_test.expect and unit_test.given now support format: sql

These changes seem OK to merge to me, approving this PR.

Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, summarized changes in #37 (comment)

@jtcohen6 jtcohen6 merged commit f58f8c1 into main May 2, 2024
5 checks passed
@jtcohen6 jtcohen6 deleted the jerco/update-manifest-v12-2024-05-01 branch May 2, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants