Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated unique test #108

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Remove duplicated unique test #108

merged 2 commits into from
Nov 17, 2021

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Nov 17, 2021

Remove duplicated test. This will start raising an error in dbt Core v1.0.0. This change is backwards-compatible and can go into a patch release.

We'll want to swing back, here and in other packages, to rename dbt_project.yml configs so as to silence deprecation warnings. Those will be backwards-incompatible and will require minor version releases.

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@joellabes
Copy link
Contributor

OHHHHHH this is only illegal in v1.0. I couldn't work out how I was the only person impacted by this.

@jtcohen6 jtcohen6 merged commit b63a562 into master Nov 17, 2021
@joellabes joellabes deleted the rm-duplicate-test branch February 14, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants