Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up tox ini #105
Clean up tox ini #105
Changes from 2 commits
7c29fbf
90d0eaa
a0f6098
089a303
95ef130
128b36b
769948a
f272aac
b24d54e
e78bd18
17f7bda
a4f740a
8b73ad0
0118899
0ee10f3
f0cbaa0
7dec753
b6c8317
ce4cd67
85f33c4
0b02e09
a727d7e
b83ede5
bceaaaa
4bf9a26
e64f5d0
f3ca75a
6036a7d
1cac631
72b86ab
bf656fa
b586e56
a17bb8f
6e12def
cf2f40c
e3c21c1
9b5f93f
932fb43
9aac92d
4d24878
e90a6eb
794a6c9
e652ba0
26f2780
88f6b7d
6495a25
1cc601f
6f55f8b
29316ea
226f35c
6bf6542
4bf8887
2745bd8
1fb8353
c72119c
cb25c02
d9d1717
adf4e45
80c4dd2
d12a1e2
de0a9e8
04681ba
8127bb2
6699419
870b283
1ded9d7
50c41fa
41f3919
aa9f4ac
5cab4d4
fc8e233
aa8771a
5f0bfd2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fairly certain that we want to keep the tilde character bc (according to this SO answer), it is a combination of to a combination of the following clauses:
>= 0.19.0
and== 0.19.*
This way a user will get an error if they try to install
dbt-core==0.20.0
before we cut a compatible release.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that is true. Though, we might miss when there is a new minor version and thus forget to leverage that.
The projects I use as examples - like
[tox](https://github.com/tox-dev/tox/blob/master/setup.cfg)
or[pre-commit](https://github.com/pre-commit/pre-commit/blob/master/setup.cfg)
- have lower bounded requirement version. Sometimes you see an upper bound for the major releasedbt-core>=0.19.0,<1.0.0
.I think the idea is that
dbt-core
should be backwards compatible for minor releases, however, it could of course happen that that is not the case.I will change it back to the
~
for now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. no strong opinion here. @mikaelene might have one though!