Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #213 - dbt test error when source name contains spaces and/or dots #214

Conversation

Freia3
Copy link

@Freia3 Freia3 commented Apr 13, 2022

remove spaces and dot in index name, add qoutes around schema and table name when creating or dropping index

@Freia3 Freia3 changed the title remove spaces and dot index name, add qoutes around schema and table name when creating or dropping index Fix dbt test error when source name contains spaces and/or dots Apr 13, 2022
@Freia3 Freia3 force-pushed the fix-issue-dbt-test-source-name-with-spaces branch 2 times, most recently from 1bcc55c to 24a1a17 Compare April 13, 2022 13:51
@Freia3 Freia3 changed the title Fix dbt test error when source name contains spaces and/or dots Fix https://github.com/dbt-msft/dbt-sqlserver/issues/213 - dbt test error when source name contains spaces and/or dots Apr 13, 2022
@Freia3 Freia3 changed the title Fix https://github.com/dbt-msft/dbt-sqlserver/issues/213 - dbt test error when source name contains spaces and/or dots Fix #213 - dbt test error when source name contains spaces and/or dots Apr 13, 2022
@sdebruyn sdebruyn linked an issue May 22, 2022 that may be closed by this pull request
@sdebruyn sdebruyn added this to the v1.1.2 milestone Jun 2, 2022
@Freia3 Freia3 force-pushed the fix-issue-dbt-test-source-name-with-spaces branch from c874ae5 to 74498f1 Compare June 7, 2022 12:19
put back original relation_name
@Freia3 Freia3 force-pushed the fix-issue-dbt-test-source-name-with-spaces branch from 74498f1 to 8588540 Compare June 7, 2022 12:23
@sdebruyn sdebruyn self-requested a review June 7, 2022 13:16
sdebruyn added a commit that referenced this pull request Jun 7, 2022
@sdebruyn sdebruyn merged commit bc75fc0 into dbt-msft:master Jun 7, 2022
Copy link
Member

@sdebruyn sdebruyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbt test fails because of space in source name
2 participants