Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit setup #228

Merged
merged 6 commits into from
May 22, 2022
Merged

Pre-commit setup #228

merged 6 commits into from
May 22, 2022

Conversation

sdebruyn
Copy link
Member

@sdebruyn sdebruyn commented May 21, 2022

Setting up pre-commit for this repo. It works well except for mypy which complains that dbt-sqlserver is not a valid package name.

@sdebruyn sdebruyn force-pushed the pre-commit-setup branch from e523e2d to bf1a6df Compare May 21, 2022 19:55
@sdebruyn sdebruyn requested a review from dataders May 21, 2022 20:06
@sdebruyn sdebruyn merged commit 4eff323 into master May 22, 2022
@sdebruyn sdebruyn deleted the pre-commit-setup branch May 22, 2022 07:51
@dataders
Copy link
Collaborator

@sdebruyn do docs on how the pre-commit works? i'm a pre-commit newb. perhaps we make additions to the CONTRIBUTING.md?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants