Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run CI tests on trusted PRs and include secrets #239

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Conversation

sdebruyn
Copy link
Member

@sdebruyn sdebruyn commented Jun 2, 2022

CI tests were failing on PRs from external contributors because the secrets were not available

this changes that so that the tests without secrets always run and the tests needing secrets are only triggered when you add the label safe to test

@sdebruyn sdebruyn requested a review from dataders June 2, 2022 20:05
@sdebruyn sdebruyn added this to the v1.1.0 milestone Jun 2, 2022
Copy link
Collaborator

@dataders dataders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet! just wondering -- what tests are not sensitive tests? my gut tells me the "local" sqlserver tests need not be sensitive

@sdebruyn
Copy link
Member Author

sdebruyn commented Jun 2, 2022

@dataders All tests requiring access to our Azure env should be approved by a maintainer to avoid a pull request becoming a pwn request. The other ones run isolated and don't need external resources so they are always triggered

@sdebruyn sdebruyn merged commit f24f3f4 into master Jun 3, 2022
@sdebruyn sdebruyn deleted the run-pr-tests branch June 4, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants