535 implement postgres style index creation #573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the SQL Server adapter in the
dbt
project, primarily focusing on adding support for index configurations based on the postgresql adapter implementation. The changes include new classes for index configuration, updates to the SQL Server adapter to handle these configurations, and corresponding test updates. Closes #535 .Index Configuration Enhancements:
SQLServerIndexConfig
,SQLServerIndexConfigChange
, andSQLServerIndexType
to handle index configurations and their validations (dbt/adapters/sqlserver/relation_configs/index.py
).__init__.py
file to include the new index configuration classes (dbt/adapters/sqlserver/relation_configs/__init__.py
). [1] [2]Adapter Updates:
SQLServerConfigs
to manage adapter-specific configurations, including indexes (dbt/adapters/sqlserver/sqlserver_configs.py
).SQLServerAdapter
class (dbt/adapters/sqlserver/sqlserver_adapter.py
).SQLServerConfigs
in theSQLServerAdapter
class (dbt/adapters/sqlserver/sqlserver_adapter.py
).Macro and Test Updates:
sqlserver__get_create_index_sql
to generate SQL for creating indexes based on the new configurations (dbt/include/sqlserver/macros/adapter/indexes.sql
).tests/functional/adapter/mssql/test_index_macros.py
). [1] [2] [3] [4] [5]Still pending: