Add CI tests for different target connection configs #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
reviewed
Jan 5, 2021
| encrypt: yes | ||
| trust_cert: yes | ||
| azuresql_sqlcred: &azuresql | ||
| <<: *sqlserver |
There was a problem hiding this comment.
For my understanding, is this a way to extend de above mentioned profiles, the ones with &<some name>?
There was a problem hiding this comment.
they're called YAML anchors, and I'm on the fence about them legibility-wise. Seems pretty easy to go overboard on. how would you rate the readability of this YAML file, @JCZuurmond?
https://support.atlassian.com/bitbucket-cloud/docs/yaml-anchors/
There was a problem hiding this comment.
I like the anchors, indeed you should not use it too much, but it narrows what your focusing on within each segment. For example with sqlserver_local_encrypt it is clear that encrypt: yes and trust_cert: yes is what should be tested - it's like a fixture in testing
jtcohen6
approved these changes
Jan 5, 2021
| encrypt: yes | ||
| trust_cert: yes | ||
| azuresql_sqlcred: &azuresql | ||
| <<: *sqlserver |
|
Great Work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #65. basically now we have 3 different target configs to test against:
EncryptandTrustServerCertificatearen't specifiedEncryptandTrustServerCertificateare specifiedConnection types still lacking coverage are:
windows_login=Truebecause it would require a Windows VM, but we can open a new PR for that in the future.az clishortly anyway@Mikael any must have connection type coverage? If not, I'd say let's merge this so we can: