Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit-helper: make commented out sql TSQL compliant #54

Merged
merged 2 commits into from
Jun 25, 2021
Merged

audit-helper: make commented out sql TSQL compliant #54

merged 2 commits into from
Jun 25, 2021

Conversation

dataders
Copy link
Contributor

@dataders dataders commented Jun 24, 2021 •
edited
Loading

turns out the commented out SQL is very helpful! it needs a tweak that we didn't address in the first round

@dataders dataders changed the title Update compare_queries.sql audit-helper: make commented out sql TSQL compliant Jun 24, 2021
@dataders dataders requested a review from alieus June 24, 2021 21:00
@dataders dataders marked this pull request as ready for review June 24, 2021 21:04
@alieus
Copy link
Contributor

alieus commented Jun 24, 2021

@swanderz , should this remain commented out?

alieus
alieus approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@alieus alieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dataders dataders merged commit b0449e4 into main Jun 25, 2021
@dataders dataders deleted the allow-full-query-auditing branch November 12, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alieus alieus alieus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dataders @alieus