Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More FFI discipline #42

Closed
2 of 3 tasks
dbuenzli opened this issue Nov 30, 2022 · 1 comment
Closed
2 of 3 tasks

More FFI discipline #42

dbuenzli opened this issue Nov 30, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@dbuenzli
Copy link
Owner

dbuenzli commented Nov 30, 2022 •
edited
Loading

For upcoming effect support

  1. Replace as much as possible the external primitives in Jv and Jstr by corresponding calls to Jsoo_runtime.Js. Not essential, but in general safer and more robust to changes. This is now tracked by Rely more on Jsoo_runtime rather than external #45.

  2. Review the callback stuff in brr we need to use the callback stuff provided in Jsoo_runtime.Js. This is essential and not done at the moment.

  3. Review and update the cookbook bits on callbacks and OCaml function export to JavaScript.
@dbuenzli dbuenzli added the enhancement New feature or request label Nov 30, 2022
@vouillon vouillon mentioned this issue Dec 1, 2022
Closed
dbuenzli pushed a commit that referenced this issue Dec 5, 2022
@vouillon @dbuenzli
Wrap OCaml functions before passing them to JavaScript (#42).
b14c3f9 
This is necessary to deal with the calling convention mismatch
introduced by the upcoming effect support (ocsigen/js_of_ocaml#1340)
dbuenzli added a commit that referenced this issue Dec 5, 2022
@dbuenzli
Continue parent patch 677bdfb338b (#42).
c64b00b 
- Tweak definitions suggested by Jérôme.
- Fix Ev.listen (type' became t which was an arg of the fun).
- Update cookbook.
- Review all `Jv.repr` uses to hunt for callbacks.
@dbuenzli
Copy link
Owner Author

dbuenzli commented Dec 5, 2022

Except for the first unrelated point which is now tracked by #45 This has been solved.

@dbuenzli dbuenzli closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbuenzli