Skip to content

Commit

Permalink
Don't run cargo update on msrv test
Browse files Browse the repository at this point in the history
This lets us not break on msrv bumps in our dependencies in keeping with
the policy at https://doc.rust-lang.org/nightly/cargo/reference/rust-version.html
which says "it is expected that each dependency’s version-requirement
supports at least one version compatible with your rust-version.
However, it is not expected that the dependency specification excludes
versions incompatible with your rust-version."

A downside is that committing an updated Cargo.lock may cause msrv
breakage at that time.
  • Loading branch information
dburgener committed Dec 17, 2024
1 parent 1e72fd6 commit 38d337e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ jobs:
strategy:
matrix:
rust:
- $MSRV
- stable
- beta
- nightly
Expand All @@ -28,6 +27,8 @@ jobs:
include:
- rust: stable
cargo-update: false
- rust: $MSRV
cargo-update: false
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@master
Expand Down

0 comments on commit 38d337e

Please sign in to comment.