Add an API similar to GDBusMessage::from_blob

[zeenix]

In GitLab by @SeaDve on Mar 16, 2023, 15:44

Currently, there is zbus::Message::from_raw_parts. However, it is private.

For the use case, Bustle has DBus messages serialized in a pcap file. There is currently not a convenient way to parse the bytes from each packet from the pcap file into a zbus::Message.

Link

• GDBusMessage.new_from_blob

[zeenix]

Thanks for reporting this but I guess I wasn't clear on the matrix channel when we discussed this. I don't need to consider this, I think we should provide such an API. I suggested we make zbus::Message::from_raw_parts public as part of MessageBuilder. Would it be possible to provide a MR?

[zeenix]

In GitLab by @SeaDve on Mar 16, 2023, 16:07

Ahhh. yeah, sure

[SeaDve]

I'm sorry if I took too long to get back to this.

I am a bit puzzled about how the API should look, but my understanding of what you suggested is to have something like this, or should it be something different like returning the Builder, instead?

impl MessageBuilder {
    pub fn from_raw_parts(bytes: Vec<u8>, ...) -> Message {
        ...
    }
}

[zeenix]

I am a bit puzzled about how the API should look, but my understanding of what you suggested is to have something like this, or should it be something different like returning the Builder, instead?

Out of pure coincidence I had to use something similar myself yesterday in busd code to create a modified copy of a message. There I used MessageBuilder::build_raw_body combined with TryFrom<MessageHeader> for MessageBuilder impl I just added yesterday. However that's more building messages from separate parts instead.

For building a full Message from raw bytes. I'd just add a TryFrom<&[u8]> impl for Message.