Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move zbus::{quick_}xml to a separate crate? #413

Closed
elmarco opened this issue Jul 26, 2023 · 1 comment · Fixed by #449
Closed

Move zbus::{quick_}xml to a separate crate? #413

elmarco opened this issue Jul 26, 2023 · 1 comment · Fixed by #449
Labels
api break zbus Issues/PRs related to zbus crate
Milestone
zbus-4.0

Comments

@elmarco
Copy link
Contributor

elmarco commented Jul 26, 2023 •
edited
Loading

SSIA. It looks like we could have made it a different crate. It's not used by zbus internals, nor does it use internals of zbus (just zbus_names).
@elmarco elmarco changed the title Move zbus::{quick_}xml to a seperate crate? Move zbus::{quick_}xml to a separate crate? Jul 26, 2023
@zeenix
Copy link
Contributor

zeenix commented Jul 27, 2023

Agreed. Also we can now ditch serde-xml.

@zeenix zeenix added api break zbus Issues/PRs related to zbus crate labels Jul 27, 2023
zeenix added a commit to mercedes-benz/zbus that referenced this issue Aug 18, 2023
@zeenix
🚚 Move xml mod into a separate crate, zbus_xml
9acc309 
Fixes dbus2#413.
@zeenix zeenix mentioned this issue Aug 18, 2023
Merged
zeenix added a commit to mercedes-benz/zbus that referenced this issue Aug 18, 2023
@zeenix
🚚 Move xml mod into a separate crate, zbus_xml
b93560b 
Fixes dbus2#413.
@zeenix zeenix added this to the zbus-4.0 milestone Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api break zbus Issues/PRs related to zbus crate
Projects
None yet
Milestone
zbus-4.0
Development

Successfully merging a pull request may close this issue.

🚚 Move xml mod into a separate crate, zbus_xml mercedes-benz/zbus
2 participants
@zeenix @elmarco