Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error with zbus_names #667

Closed
frewsxcv opened this issue Feb 29, 2024 · 2 comments
Closed

Compile error with zbus_names #667

frewsxcv opened this issue Feb 29, 2024 · 2 comments

Comments

@frewsxcv
Copy link

https://github.com/frewsxcv/rgis/actions/runs/8099496834/job/22135370933

   Compiling zbus_names v2.6.0
     Running `/home/runner/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/rustc --crate-name zbus_names --edition=2018 /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zbus_names-2.6.0/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C embed-bitcode=no -C debuginfo=2 -C metadata=8a0ee94d8db63222 -C extra-filename=-8a0ee94d8db63222 --out-dir /home/runner/work/rgis/rgis/target/x86_64-unknown-linux-gnu/debug/deps --target x86_64-unknown-linux-gnu -L dependency=/home/runner/work/rgis/rgis/target/x86_64-unknown-linux-gnu/debug/deps -L dependency=/home/runner/work/rgis/rgis/target/debug/deps --extern serde=/home/runner/work/rgis/rgis/target/x86_64-unknown-linux-gnu/debug/deps/libserde-747431a5716c84fa.rmeta --extern static_assertions=/home/runner/work/rgis/rgis/target/x86_64-unknown-linux-gnu/debug/deps/libstatic_assertions-fb671e4e595b58be.rmeta --extern zvariant=/home/runner/work/rgis/rgis/target/x86_64-unknown-linux-gnu/debug/deps/libzvariant-ccb1ef7ee66a4faf.rmeta --cap-lints allow`
error[E0277]: the trait bound `zvariant::Str<'_>: From<Cow<'_, str>>` is not satisfied
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zbus_names-2.6.0/src/bus_name.rs:263:9
    |
263 |         Str::from(value).try_into()
    |         ^^^ the trait `From<Cow<'_, str>>` is not implemented for `zvariant::Str<'_>`
    |
    = help: the following other types implement trait `From<T>`:
              <zvariant::Str<'name> as From<BusName<'name>>>
              <zvariant::Str<'name> as From<unique_name::UniqueName<'name>>>
              <zvariant::Str<'name> as From<well_known_name::WellKnownName<'name>>>
              <zvariant::Str<'name> as From<InterfaceName<'name>>>
              <zvariant::Str<'name> as From<MemberName<'name>>>
              <zvariant::Str<'name> as From<ErrorName<'name>>>
              <zvariant::Str<'a> as From<&'a str>>
              <zvariant::Str<'a> as From<&'a std::string::String>>
            and 8 others

error[E0277]: the trait bound `zvariant::Str<'_>: From<Cow<'_, str>>` is not satisfied
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zbus_names-2.6.0/src/utils.rs:8:33
    |
8   |                       let value = Str::from(value);
    |                                   ^^^ the trait `From<Cow<'_, str>>` is not implemented for `zvariant::Str<'_>`
    |
   ::: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zbus_names-2.6.0/src/unique_name.rs:287:1
    |
287 | / impl_try_from! {
288 | |     ty: UniqueName<'s>,
289 | |     owned_ty: OwnedUniqueName,
290 | |     validate_fn: ensure_correct_unique_name,
291 | |     try_from: [&'s str, String, Arc<str>, Cow<'s, str>, Str<'s>],
292 | | }
    | |_- in this macro invocation
    |
    = help: the following other types implement trait `From<T>`:
              <zvariant::Str<'name> as From<BusName<'name>>>
              <zvariant::Str<'name> as From<unique_name::UniqueName<'name>>>
              <zvariant::Str<'name> as From<well_known_name::WellKnownName<'name>>>
              <zvariant::Str<'name> as From<InterfaceName<'name>>>
              <zvariant::Str<'name> as From<MemberName<'name>>>
              <zvariant::Str<'name> as From<ErrorName<'name>>>
              <zvariant::Str<'a> as From<&'a str>>
              <zvariant::Str<'a> as From<&'a std::string::String>>
            and 8 others
    = note: this error originates in the macro `impl_try_from` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0277]: the trait bound `zvariant::Str<'_>: From<Cow<'_, str>>` is not satisfied
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zbus_names-2.6.0/src/utils.rs:8:33
    |
8   |                       let value = Str::from(value);
    |                                   ^^^ the trait `From<Cow<'_, str>>` is not implemented for `zvariant::Str<'_>`
    |
   ::: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zbus_names-2.6.0/src/well_known_name.rs:300:1
    |
300 | / impl_try_from! {
301 | |     ty: WellKnownName<'s>,
302 | |     owned_ty: OwnedWellKnownName,
303 | |     validate_fn: ensure_correct_well_known_name,
304 | |     try_from: [&'s str, String, Arc<str>, Cow<'s, str>, Str<'s>],
305 | | }
    | |_- in this macro invocation
    |
    = help: the following other types implement trait `From<T>`:
              <zvariant::Str<'name> as From<BusName<'name>>>
              <zvariant::Str<'name> as From<unique_name::UniqueName<'name>>>
              <zvariant::Str<'name> as From<well_known_name::WellKnownName<'name>>>
              <zvariant::Str<'name> as From<InterfaceName<'name>>>
              <zvariant::Str<'name> as From<MemberName<'name>>>
              <zvariant::Str<'name> as From<ErrorName<'name>>>
              <zvariant::Str<'a> as From<&'a str>>
              <zvariant::Str<'a> as From<&'a std::string::String>>
            and 8 others
    = note: this error originates in the macro `impl_try_from` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0277]: the trait bound `zvariant::Str<'_>: From<Cow<'_, str>>` is not satisfied
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zbus_names-2.6.0/src/utils.rs:8:33
    |
8   |                       let value = Str::from(value);
    |                                   ^^^ the trait `From<Cow<'_, str>>` is not implemented for `zvariant::Str<'_>`
    |
   ::: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zbus_names-2.6.0/src/interface_name.rs:145:1
    |
145 | / impl_try_from! {
146 | |     ty:InterfaceName<'s>,
147 | |     owned_ty: OwnedInterfaceName,
148 | |     validate_fn: ensure_correct_interface_name,
149 | |     try_from: [&'s str, String, Arc<str>, Cow<'s, str>, Str<'s>],
150 | | }
    | |_- in this macro invocation
    |
    = help: the following other types implement trait `From<T>`:
              <zvariant::Str<'name> as From<BusName<'name>>>
              <zvariant::Str<'name> as From<unique_name::UniqueName<'name>>>
              <zvariant::Str<'name> as From<well_known_name::WellKnownName<'name>>>
              <zvariant::Str<'name> as From<InterfaceName<'name>>>
              <zvariant::Str<'name> as From<MemberName<'name>>>
              <zvariant::Str<'name> as From<ErrorName<'name>>>
              <zvariant::Str<'a> as From<&'a str>>
              <zvariant::Str<'a> as From<&'a std::string::String>>
            and 8 others
    = note: this error originates in the macro `impl_try_from` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0277]: the trait bound `zvariant::Str<'_>: From<Cow<'_, str>>` is not satisfied
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zbus_names-2.6.0/src/utils.rs:8:33
    |
8   |                       let value = Str::from(value);
    |                                   ^^^ the trait `From<Cow<'_, str>>` is not implemented for `zvariant::Str<'_>`
    |
   ::: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zbus_names-2.6.0/src/member_name.rs:149:1
    |
149 | / impl_try_from! {
150 | |     ty: MemberName<'s>,
151 | |     owned_ty: OwnedMemberName,
152 | |     validate_fn: ensure_correct_member_name,
153 | |     try_from: [&'s str, String, Arc<str>, Cow<'s, str>, Str<'s>],
154 | | }
    | |_- in this macro invocation
    |
    = help: the following other types implement trait `From<T>`:
              <zvariant::Str<'name> as From<BusName<'name>>>
              <zvariant::Str<'name> as From<unique_name::UniqueName<'name>>>
              <zvariant::Str<'name> as From<well_known_name::WellKnownName<'name>>>
              <zvariant::Str<'name> as From<InterfaceName<'name>>>
              <zvariant::Str<'name> as From<MemberName<'name>>>
              <zvariant::Str<'name> as From<ErrorName<'name>>>
              <zvariant::Str<'a> as From<&'a str>>
              <zvariant::Str<'a> as From<&'a std::string::String>>
            and 8 others
    = note: this error originates in the macro `impl_try_from` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0277]: the trait bound `zvariant::Str<'_>: From<Cow<'_, str>>` is not satisfied
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zbus_names-2.6.0/src/utils.rs:8:33
    |
8   |                       let value = Str::from(value);
    |                                   ^^^ the trait `From<Cow<'_, str>>` is not implemented for `zvariant::Str<'_>`
    |
   ::: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zbus_names-2.6.0/src/error_name.rs:147:1
    |
147 | / impl_try_from! {
148 | |     ty: ErrorName<'s>,
149 | |     owned_ty: OwnedErrorName,
150 | |     validate_fn: ensure_correct_error_name,
151 | |     try_from: [&'s str, String, Arc<str>, Cow<'s, str>, Str<'s>],
152 | | }
    | |_- in this macro invocation
    |
    = help: the following other types implement trait `From<T>`:
              <zvariant::Str<'name> as From<BusName<'name>>>
              <zvariant::Str<'name> as From<unique_name::UniqueName<'name>>>
              <zvariant::Str<'name> as From<well_known_name::WellKnownName<'name>>>
              <zvariant::Str<'name> as From<InterfaceName<'name>>>
              <zvariant::Str<'name> as From<MemberName<'name>>>
              <zvariant::Str<'name> as From<ErrorName<'name>>>
              <zvariant::Str<'a> as From<&'a str>>
              <zvariant::Str<'a> as From<&'a std::string::String>>
            and 8 others
    = note: this error originates in the macro `impl_try_from` (in Nightly builds, run with -Z macro-backtrace for more info)
@frewsxcv frewsxcv changed the title Compile error with zbus_names, maybe only on nightly Rust? Compile error with zbus_names Feb 29, 2024
@zeenix
Copy link
Contributor

zeenix commented Feb 29, 2024

Right, I think we ended up using yet unreleased API from zvariant in zbus_names. 🤦 As a workaround, you can cargo update -p zvariant and it should hopefully work. I'll try release a zbus_names 3.x release to fix this.

zeenix added a commit that referenced this issue Feb 29, 2024
In 2.6.0, we ended up using API from zvariant 3.15 and didn't bump our
requirement. Let's do that.

Fixes #667.
@zeenix
Copy link
Contributor

zeenix commented Feb 29, 2024

I rolled out zbus_names 2.6.1 that should fix this issue.

@zeenix zeenix closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants