feat: add reference inputs used lang to script hash calc #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joacohoyos
force-pushed
the
clark/add-languages-to-safe-hash-calc-for-reference-inputs
branch
from
d073f18
to
984e637
Compare
joacohoyos
requested review from
SebastienGllmt
and removed request for
MicroProofs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using just script reference inputs no languages were passed to the calc script hash function. This caused an error in the generated safe hash not allowing the tx to be submitted.
Now, we go through both inputs and reference inputs and if there is a script in any of them we add the language
cc: @MicroProofs